Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Feat/exchange account schema #11

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Feat/exchange account schema #11

wants to merge 17 commits into from

Conversation

dzdidi
Copy link
Contributor

@dzdidi dzdidi commented Mar 10, 2023 •
edited
Loading

LNM slashfeed.json:

{
  "name": "LNMarkets",
  "description": "Up-to-date insight into your LNMarkets account performance",
  "type": "exchange_account_feed",
  "version": "0.0.1",
  "icons": {
    "200": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAIAAAAiOjnJAAASiklEQVR4nOydeXBVVZrA71uTvKxkJ4QkLwmQhEASSEJAkNCMqMjYLs3itDpVo7PUzJQ6NY7ltD2NSkVnxLHtGbpnaiirphS0RTYbghhAQETa7AtmXyD7npDt5a3pgmeHkLz3cr9zz/feTdf3+wvI++495P7eWb9zrjpn228EguCN0tMFIP40IbEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgUSi0CBxCJQILEIFEgsAgW1+28ZGTj4z9tPQqP25z/eO7IIFPLQ1mVb708U//mOrpH3//cqtGDOeOPVP9P5aEAhpZWdnxyr4FWAadJSFz+9M50tdv+Br3v7xhkCPSBWTmLtxhU1oJBbEz59I4HQG+14MHlt2hJQyJdf1dfU90FvNJe4mKBtW5ZBo1KTI46crLRap6QX4G5Jlga98/pDAf7eDLHDtwx9/SxWeaYpzE5ogIYUtyROAYvq7a1elRIJvdGzuzOgIQ7JyljKEBUU6AP9JrgmJFj3Xt4ONqsEQSip6JhildzdYikVtrX6RmhUUdNyaEj6qiitRgWNun+DPiYaXDXOJXttNFvg1vsTpN/djs5H896+7Ysj/JmvUFjazhzrbrGSotoCfCahUUXN4GZl3RqWR6tUKn+6U2qlpVYp1qyOYovN3ZigVnN4KCqVIu/n25Ynhkm5SNECEis7HtwOtg8Gdw6HQKOymMQSBOHhrctDQ3RssXZWJkfqfLRssQH+XlkZjCWfyasv5uZkxki5QlvHcFfPKHO428VKqIeGFDWBq6vQYF1CHNhFOxqNas8TaWyxdtgqy2keyAWMZB3y/DOZOx5MkniRojL26srdYvlojKnRrdAohnZQ4pf+8e0p/n6MVY6UytLOpvV6Dbx3OM2OB5OeezpLSgHsSOlguVusjLgmjdoKCrHZFMUtcLGkPVqdTvvkn6eyxfr5apOXh0u5u5+vdt1alkGlIAg5mUtffXGzlLvbsdlsJeUdUq7gVrEY2sHariWjk+AeT/Yaxgczza7HVnlpWaqNtelLVCqpv9VtTK3hisTQvJ8/KP3ugiBU1/WNjZukXMGtYmXBe+4MHawEfXBIsKTetyAIi4J0bN2UbGmVpZ37cuKgWi+O8H9333boXL8zisraJF7BfWKF+Q/Hh/dCowrhHSzp1ZWdv/hJukqp8MjddT6a9dmAMV2Av9cv8x4JDfaVfms7RWWS2kG3isVQXRlMmqo2PfhGPIbrgiBERQZs3QxrkqIi/aOjOMyv3hkbiv1GaTWqd15/OHYpbCHVBQaDuaq6W+JF3CcWQwer/KbebIWtZmo0yvRVi6E3csYzwBUeiYOGmWzIivH2nv//rlAIe1/ZmpbK7b8sCEJZVafFYpN4ETeJpRCmsuLBKznF8HZwdUqkjzeffoYgCIn6kPVZgCaJVyt8Z61Ts3Fd3Lwfe+FvNvyI3yqQHYkTDXbcJFZCRFew3xg0qrAZvETI8dHaEb8srVQoMtN5LiHPO1O6+7FVEudyHSJxatSOm8TKTqiDhgyO+TX1gGt4jo2RnfRVUatSIsR8Mml5GHMegUPWZS7V6ZzWvls2xb/wtxs53s5O/+B4841B6ddxk1gMPffi5sQpATYoCwzwWpEoaXLSIU+LW5bmNWiYxkur3rzB8dglLXXx3le2KhGeHpd20E1iaVXm9NgWaBTDRMPa9GiM3/Wm9Xp97PxjLi4zWLNwmAEbGx30zusPeWlRkjSLF5BYq2NavDUWaBTDEiHGo7WPvOattLy91anwvMJ5yV4T7ed7z6plyCLde3mP8G1zZ8Klg+UmsRhSRm/0hUEz3PHEut2P3pIYEebn4gMZTHmF86LRqLZsjJ/+q4+P5t19D0dFBnC/kZ2mGwP9gxNcLuUeseCpMvDqKnpJ4OIIrN+4Rq166klX4y88p6dnE1RKRd5r25KW8e9ETlPMqbpyh1hBurFlkV3QKLeljIrnxw8nB/h7Ofsp92mOaTLTowMDbjd8r7y4GTSpxsB3JQtHrEx9g1IBy8i32BQlLeDl/Sy0R2vH21uz88erHP4oNEQXHxeMdF+1WrllY/xf/XTtow8lI93CjsViLa/q5HU1dLEY2sHq9pgJE6xzqlQq+O5vccjOR1MdLrNkpeNWls8/k/XXz2aj3kIQhKrqHsMkeIzlDHSxsuA996JmcHW1Mil81ugJg8BAH4fVRjZrXp5IpGcBiaGQXwcLXazYkJ7IwFvQqMKmFdAQhslJq5VlnfWpJ9Nm7aJRIEyNeoSiUqk5WDPBFYuhuho3aqs7wF1Uhr7zB4eKzWZYnrQgCJHh/rPSO+PheYUms7W3D7xyKhKr1Xb5ajM0anTMyGUL+DS4YmXHgztYZTcSLDbYhJBOp1mZJGo5byZnztWdvQAuniAIT+/KmLnSxOB0VXV3/jnw4qlI8t67aDSBvzAl5R02G8+t/YhiqZXWNXrwV4dlJSdtCXSTZ2v7cE/f2OHPyhm2kOtjgzeuv5vQwtAOFpW25RfUgm8sgv/6v6tnz9czJFnwmnCfBlGslCWtvl5GaBTLZi/4DFbhnf7EzfZhhlZDEIRnd/2wwqPRKDPgeYWFpe0dXSMcx/Z2Dh0p++RYZYI+OHgRuLPPa+15GkSxGFJlekcCbvSBG7Vshjrjj1/Qj46UQWMFQUhNibQnba5eudgbmFc4MjpZ19AvCALfSuvU2Zpff/B7+4QqNLare6S9EzzGcg2iWAwpo3eqK1iqTESYHzTd22q1lVb8UFtU1/WWVLBsHPjLPRlsTheXd9juNMAXrjQbJs0Mt57L5avN//Gry/Y/s9TfvNtBRLF8vQwp8E3PxfAZLIbfY01978xNcx99Wgq9giAI67NiE/UhDKfKTJ+0YTCYL15pYrj1LMoqO3/x7+etd7rearUyYxX4PBIph384A0ustfpGtRLYMZ4SCuHHFTGs/s7qqH5X0l7XyDLS/ofnc5YngJeEC2dMF50ukDo2bGjq/5e9X5j+OAxMTYrwAW4ttNmE4vKFIxbDqTJNvRGD47D0BIWCZVA2t6PK1tPKyYyB5hV2dN3q7L57hEt5ZWdn1wjDre20d9566bXT4xN3a1+Gr1l9U9+tEfAYa17QxIIvETJsnViWEBoU6AMKMRjM12t6Zv3jpSvN3HuvDpnV6EwJwpnzjJXWwOD4Sz87PThkmPmPmawDZO6giBUZOLg0ZAAaxbCbfh18ctLhpjmrberjo+XQSzEwt7LML6hlmEsbGzO+9Fp+x721na9Ow3AeCfcZLDsoYjFUV2aLquxmPDSKoefurKN6uqBucIhP8qQzbDbb3BFod+9YCbCLMzlpfnnvF43Ns7+6a9KWqIEngkwaLZXXpW56dghKQj6DWFXtMZNmp2l0zjh+6vqps7ADmJ1NLpjN1t8er/j759ZDyyCe2oa+kVEHvZn8c3WZonuKVqvtF2+fr7juIHeSobtZcb3LBF8wFQN/sRSCLdMtx9fe7htdBW/+ccGJ/Opn96zx8wX7LRJnleXFb5pf/sdNvjpRaT9vv3/pyu9vOPwR2+ISNEQk/JvCpKj2QJ0BGsWQg8WdsXHTifxqvOs7m4c0Gi0XvhY1oXXg4Lf5TmYowkJ942LA20+4r+RMw18shr2powbvmk7cbG6RfHq80mTilkU5E8OkqyNc8r+cv0E/fLT88FGn761gqK6Ghg1zO2q8QBAL3sEquZFgm5LFW30GhiaYx/+uKa/qMpudphZWVve0tg+7CM8vqD1w8JqLD2RlsGQ08EyUuRfOj9NbY1y99CY0iiGjAY/Dn1XYbFIP8ZnLvKP6M84ztK5ca3n7l5dch4vv/t8tElo7yF+s9NgWLfD42ju5yCw9dyTaO29dvMKSS+OaebvJZ87XORS6rKrz3946Z3WZhaePXcRwnF+h5PMgXcBZLIaJhq7hoPZBSS9Q4M6HTCs8LhgYmmhqmecIl77+8blVSENz/yt7v5g3I5RhJedm2xDba71Ewnm6gaHnPmnWPpdbwLcYDrlck9rYI2rlv76xv7C0jeMe1KJSUb2Z0wW162a8TqKja+SffpYv5vRihndCYaTKzISnWCF+I4nh4GlcfVjv87nnOBbDIY3dkR9e+ZH4z3/4aRlPscQ9xa+v3RgdM/r7eQmCMDg08eK/nhoQsRigVikyVoOzWFE7WJybwqz4emCWnpswWVRvntgDOs60pLyjug58xrMzRD5Fk8l67tLtKn983PTSa6c7xCU+rEyOgL66x2K1lTKlN4qHq1jwzV7u4YNLDzT0gEfjhzj1tFpaB/sGxPZm8gvqjEbLy3vPNDSJnWFimMGqru0Zn+CTvOoMjmJNMWz2cgOVrbGHrm5hCLx8taW1bUh6AYogJ21U1/U+98Kx8irAMSoMSe7Sj3GfF25ixYd3h/pjbcJkZsKkffPEHrbZV9vU1KHPOOTSQLvJTZAjQHU+LHsqkXKwZsJNLHlWVwcKHukYCmUOP3uhnvmlyHYsFmtZJedtXjNZkxYF3VM5PmGqrp2d6sgdfmLJr4N1rWH5iWJJaTBmi+23JyS9Vv772t4JA2JvhuGgm7LKTgvX95k7hI9YapUlPZb/bLUURgw+b32+C7qZbC4n8qtHx9hTwrEbHfnkIs+Cj1irl7b4aHFHGVD2n368f4zDa20MBvOx311nDsfLS7G/SDY+FnzgG1Iu8iz4iMWwJweVc1Vp57+X+s7waY58XmU0suTSjI2bOE6GzYVh4bm3b+xGq6s0Cl7wEUtWM1h9o/7785/geMGhYcPpL1m2w5dUcD7CZRYsKaNuqa74iBXgM54UhT4vIpYpIe/kLoaXsrrm42PlDAe14SX+2mHIwUJtmmfCQaxMfSP0+Fo8jhfnfNck9QXuc+nsHj1/GZ7Ij1k9xMUsCgt1dfT8XKamUDY9O4SDWAypMki0DYQcOLcD6eKHjsAmS7t7RlvbETfBMrSDjS39sza44sEhu8FsVX1Th3tStCAI9y2vUbicOrDZFPtO7jaYsPbYNLYMHD5aHhsdJPLzoGUZBry0qm+cbNdxxrdF4GNamFHkbPuN227GzIrI9v//u1+5/syHV7b8z4Xt7ioRMQ+y2MIwL5uTq1x/oKF78cFL29xVHGJ+FoZYuSmupihNFtUbx/dYgG+PJlBZAGLFhvTow1xNMx68uK2pF3zaGIHKAhBrc7Kr6qriZtzH3+a6sTiEKBaCWElOxZowaved3C2Tza7ETOT+SMIDhlKWOJ3T+++CHVLSrQg85C7W7XbQyfTVt/VJJ0ty3F0gQhxyFyvXSQdreEL31u9+Ij3dikBC1mIF6cbSYhyfgLX/9BMDPNKtCCRkLdamFd+rHJ3pXVCZ/lW1qzc0Ex5H1mI5nGjoHQl498zjnigOAUC+Yum0kw5OgpgS8j7fyT3diuCOfMXasKxm7olIx4rWFyKkWxHcka9Yc9vBtoHQA+ce8VBxCBgyFUurNm9Yfk+audWmePPEboYjuwmPIFOxsuPrddp7zoX66Jst19vjPFciAoZMxcq9NwGrvmvxB5ce8FxxCDByFEultN634u7x1EaL+o0TT1lslG61kJCjWOkxzUG6uyfZHfxqW3Mv+MQ6wrPIUazclLvtYPnNuE+ubfZocQgWZCeWQpi6P+l7+58njOynWxGeRXbPLGVJa3jAD2dvvn/20a7hEE+XiGBBdmJNjwev1iWdKsv2dHEIRmQnln3CfXhC99apnZRutXCRl1gJ4V32d/6+c+qJwTHYi8cJWSEvsewbU89WZFysoXSrhY3cxLrecyvwP794zNMFIaQiI7GigvqXRXTlfb5rjNKtFj4yEis3+frRwg1FzTJ6xRzBjIzE0of3/JrSrf5UkItYi3Sjx4vWGy2wlw0RskUuKQPDE75DE/6eLgXBDbnUWFOyKQnBBXqcBAokFoECiUWgQGIRKJBYBAokFoECiUWgQGIRKJBYBAokFoECiUWgQGIRKJBYBAokFoECiUWgQGIRKJBYBAokFoECiUWgQGIRKJBYBAokFoECiUWgQGIRKJBYBAokFoECiUWgQGIRKJBYBAokFoECiUWgQGIRKJBYBAokFoECiUWg8IcAAAD//5qTz8XMg5moAAAAAElFTkSuQmCC"
  },
  "fields": [
    {
      "type": "balance",
      "name": "total balance",
      "description": "Total balance",
      "main": "/feed/total-balance/",
      "units": "sats"
    },
    {
      "type": "pnl",
      "name": "total open pnl",
      "description": "Total open Profit and Loss",
      "main": "/feed/total-open-pnl/",
      "units": "sats"
    },
    {
      "type": "pnl_and_balance",
      "name": "total open pnl and total balance",
      "description": "Bitcoin open Profit and Loss and Total balance",
      "main": "/feed/total-open-pnl-and-total-balance/",
      "units": "sats"
    }
  ]
}

Seeded accounts:
slashfeed:citwzdpbmkgabmz9hscmap9cmjwkxt94m3coktb3e4obf4m6ecno#encryptionKey=ttium34uzwqkztg39t419bqgoaih5h4o3pwymyrd1f4qjdgoarmy
slashfeed:ic3o4is8mgkkg1er3n6otdz9ir9hj59t1ousm1nk6aiu9f3spzjy#encryptionKey=qyy9d8zurx5nqjqh4z7rb5ndihimmf84mzozsrmtpuf17kued73o
slashfeed:65i47yo7gfznee6wd8r7wybma6zz8bc7q5ssfint4t6t6hng87dy#encryptionKey=9qg1a3cthjf69e3regqqduyfs95fkuaq18ddtasq9ih5cdrb7qey

@dzdidi dzdidi marked this pull request as draft March 10, 2023 20:45
dzdidi added 9 commits March 11, 2023 06:25
@dzdidi
feed: refactoring, move out schema related logic to separate class
56e498b 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
feed: exchange account type validation and generation
5f718c8 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
slashfeed: new format
fc1915a 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
Feeds: rename update method, adjust logic to new schema
16bbb08 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
SlashtagsSchema: update generation to new schema
13ededd 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
ExchangeAccountFeed: generation; validation
1abafd5 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
RPC: update method renaming
5afc712 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
Feeds: return objects alignment
eb2b1df 
Signed-off-by: dzdidi <[email protected]>
@dzdidi
Readme: return objects alignement, method renaming, update fieelds ad…
c738264 
…justment to new schema

Signed-off-by: dzdidi <[email protected]>
@dzdidi dzdidi force-pushed the feat/exchange-account-schema branch from 11e9dfc to c738264 Compare March 11, 2023 06:09
@dzdidi dzdidi marked this pull request as ready for review March 13, 2023 12:24
@Nuhvi
Copy link
Collaborator

Nuhvi commented Mar 14, 2023

@dzdidi can you explain what should denomination_type and denomination_ratio be used for?

Also, probably the third field will be removed at some point if John and Aldert agreed on the multi-field selections etc.

@dzdidi
Copy link
Contributor Author

dzdidi commented Mar 14, 2023

@nazeh there are two denomination_types: main and base and denomination_ratio specifies conversion ration frombase to main as a power of 10. For conversion between main and base denomination. For example converting balance in btc (main) to balance in sats (base) by balance_base = balance_main * 10 ^ denomination_ratio. It would probably have more sense for representation with base/main units.

Also, probably the third field will be removed at some point if John and Aldert agreed on the multi-field selections etc.

Understood. Lets wait for their feedback

@Nuhvi
Copy link
Collaborator

Nuhvi commented Mar 14, 2023

@dzdidi This is a bit complex to be honest. The data I will read from the main file, is in sats, I know that from the units, and I will show ${units} ${value}, what else should Bitkit care about here?

@BitcoinErrorLog
Copy link

Agree, we discussed this in chat yesterday; it is simpler to just feed the unit type ("sats" or "BTC") and number ("1000" or "0.00001000"

@dzdidi
Copy link
Contributor Author

dzdidi commented Mar 14, 2023

@nazeh , @BitcoinErrorLog agreed. Updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzdidi @Nuhvi @BitcoinErrorLog